Skip to content

Make SPlot.to_gplot use parent's implementation - #17

Closed
llrt wants to merge 2 commits into
rdp:masterfrom
llrt:master
Closed

Make SPlot.to_gplot use parent's implementation#17
llrt wants to merge 2 commits into
rdp:masterfrom
llrt:master

Conversation

@llrt

@llrt llrt commented Jan 2, 2013

Copy link
Copy Markdown
Contributor

As referred in issue #16, SPlot.to_gplot implementation should use parent's implementation, while leaving there the method body as to allow for a specific implementation in the future.

@rdp

rdp commented Jan 2, 2013

Copy link
Copy Markdown
Owner

Could you pull from master and then submit the request/diff again? I guess
things have changed slightly since then.
Thank you!
-roger

On Tue, Jan 1, 2013 at 5:01 PM, Leandro Loriato notifications@github.comwrote:

As referred in issue #16 #16,
SPlot.to_gplot implementation should use parent's implementation, while
leaving there the method body as to allow for a specific implementation in

the future.

You can merge this Pull Request by running:

git pull https://github.com/llrt/ruby_gnuplot master

Or view, comment on, or merge it at:

#17
Commit Summary

  • Make SPlot.to_gplot use parent's implementation

File Changes

  • M lib/gnuplot.rb (10)

Patch Links

Conflicts:
	lib/gnuplot.rb

Merge with branch master from rdp/ruby_gnuplot
@llrt

llrt commented Jan 2, 2013

Copy link
Copy Markdown
Contributor Author

Sorry, I edited the file previously to your merge from issue #16 . When I issued this pull request, I realized it was not merged, but thought it would run cleanly. My mistake, sorry.

Now, I've merged your changes into my repo and we'll issue another pull request (I think it's easier this way).

Thanks rdp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants